BTS

Issue1933

Title Zsh: modify activation of completion caching
Priority wish Status resolved
Superseder Nosy List Xk2c, ft
Assigned To ft Topics has patch, zsh

Created on 2015-10-07.18:13:06 by Xk2c, last changed 2015-10-21.21:31:20 by mika.

Files
File name Uploaded Type Edit Remove
0001-modify-activation-of-completion-caching.patch Xk2c, 2015-10-07.18:13:06 text/x-diff
Messages
msg5591 (view) Author: mika Date: 2015-10-21.21:31:20
We believe that your issue has been closed by the upload of
Version 0.12.4 of grml-etc-core from Michael Prokop <mika@grml.org>.
The explanation is attached below

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 21 Oct 2015 23:22:38 +0200
Source: grml-etc-core
Binary: grml-etc-core
Architecture: source all
Version: 0.12.4
Distribution: grml-testing
Urgency: medium
Maintainer: Michael Prokop <mika@grml.org>
Changed-By: Michael Prokop <mika@grml.org>
Description:
 grml-etc-core - core etcetera files for the Grml system
Changes:
 grml-etc-core (0.12.4) grml-testing; urgency=medium
 .
   [ Frank Terbeck ]
   * [e1f02ea] zshrc: Update Lookup functions from upstream
   * [7e40be9] zshrc: Remove "allulimit" function
   * [76fb54b] zshrc: Leave all limits alone
   * [64794a6] grmlzshrc.5: Remove documentation for allulimit
   * [fd3a55f] zshrc: Add more robustness to completion caching setup
     [Closes: issue1933]
   * [ea0e7e8] zshrc: Remove unused parameter $ZSHDIR
 .
   [ Bernhard Tittelbach ]
   * [4e16818] tmux: background a window, reload config, improve binding
 .
   [ Dmitri Vereshchagin ]
   * [d0c99ea] zshrc: fix screen alias
   * [21c8c5c] grmlzshrc.t2t: update docs on screen alias
Checksums-Sha1:
 732f64ad095db963b519babf0a4206e4b887c095 1577 grml-etc-core_0.12.4.dsc
 cdf80a6440f96214e32f6ee925e1c82641bdd641 160437 grml-etc-core_0.12.4.tar.gz
 d94756367d0fd606492bac84d305f378dc180656 146454 grml-etc-core_0.12.4_all.deb
Checksums-Sha256:
 a1567362419d5f4bca5135e78353140deb6559f846877414f02aca3d773ff79d 1577 grml-etc-core_0.12.4.dsc
 1cbedc41e32787c37c2ed546355a26376dacf2ae1fab9551c9ace3e46d236b72 160437 grml-etc-core_0.12.4.tar.gz
 c93cb7e72937c8b0f6e784b97c79ddd837f0672bba2d4dfb92476d9d740ca1ae 146454 grml-etc-core_0.12.4_all.deb
Files:
 ca5224634ed68e8348a69b0aa3fe7a8f 1577 grml optional grml-etc-core_0.12.4.dsc
 b380f4e3febabe316ccd3bbe6676024e 160437 grml optional grml-etc-core_0.12.4.tar.gz
 307ef386af2e87d092ac3b034845cb41 146454 grml optional grml-etc-core_0.12.4_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWKAKJAAoJEJaoeHK36jc3xvcQAJnXeF8eqKsR1/5bA5FzBVYj
LBUalilR5/r99u+6NjjBbSUeNPXSQY/EFuG+E1Lt+DWnNvfVxqUFscXjgDuDe3gJ
wCbEuWfrc30esJWMjZ7hwM0uSMsTVpzlTYYFhHkEF6ps8nfRkaCjwt0Z08NzvEGS
voXES/ROksJa4BTw3KauJ0eecHLG9X9WefJokaiLOqvE6Igf253x7LBqABKhIKeG
Q0AnsycRTB8Ifzbbs5MQ8hmxop5XsyysIN4H9my96Z8odzTaPH5L6P/8EekS0Sip
lkKpWO+8lU32w8R4cjklRBhm3y9UaDIOEpMhfi/ULWRzKfK0+Pu7nTEzVPi5Xqq0
0g2uk6uQTLFwBdxhBU9zpFIK9x32aci0QblmSMlIjdNo4fQ4l66pktIdRZCGBANA
GEHuhdk0cuwJ+PbvcqGajiU2DL/qKhfThtTD2jPFbovOE8v2eVZJG3EafPUSraeQ
bRuDdGo+7OopCO1ATG6517HsTfRCKUWDFxmBNEdcwQSFBUqQ7GsglgNJFhk+D2cJ
M+fB2tdfgSsiR2EsHeim9y5c2fLU9Zr9rqMyWJnaRdsmc/1BOL+i0AOuZs5FshkL
qFlm+ufB0yOKWuUO9cGDFJ5FtaqZh7oYAIOLf56ydWuxnE7af+b7J0u+GygJHJhC
mKD3x+lxG6zPa/lPbEU4
=yZ4+
-----END PGP SIGNATURE-----
msg5582 (view) Author: ft Date: 2015-10-10.12:59:42
Thilo Six wrote:
>> Frank Terbeck added the comment:
>> 
>> Correction. I had to rebase my branch onto some new changes in
>> the repository, so the changes hash is actually:
>> fd3a55f78b1e316727760a92dcd3f0759013549c
>
> What did i wrong that you think you can throw a sha1 at me and know what to do
> with it. grml  ;)

It uniquely identifies the object in the repository's object database
that corresponds to the commit I wanted to reference. You can just do:

  % git show fd3a55f78b1e316727760a92dcd3f0759013549c

…to take a look at it.

You actually don't need the entire hash-sum. A unique prefix for the
repository in question would suffice. For example:

  % git show fd3a55f


Regards, Frank
msg5581 (view) Author: Xk2c Date: 2015-10-10.11:43:08
Hello Frank,

Thilo Six schrieb/wrote:

>> 3. The newly introduced parameters lack documentation in
>>    our setup's manual. ☺
> 
> I look into this.

I see you already did this. Will keep this in mind for next time.


kind regards,

     Thilo


>> ----------
>> assignedto:  -> ft
>> nosy: +ft
>> status: unread -> fixed-in-git
>>
>> _____________________________________
>> GRML issue tracker <bts@bts.grml.org>
>> <http://bts.grml.org/grml/issue1933>
>> _____________________________________
>>
>
msg5577 (view) Author: Xk2c Date: 2015-10-10.09:37:34
Frank Terbeck schrieb/wrote:

> Hi Thilo.
> 
> I've looked at your patch this afternoon. 

Thank you for your time!


> A couple of things:
> 
> 1. I think your approach does more than we should: If someone
>    wishes to use a different setup from ours, they should be
>    able to disable our customizations. You're doing that, which
>    is good. But then, I don't think we need to check for any
>    predefined styles.

OK. Actually this was a prof of concept to myself. I trust your judgement.

> 2. My eyes tripped over the GRML_COMPLFOO names a couple of
>    times. This is purely subjective of course. But I've changed
>    the names to GRML_COMP_FOO which for some reason make my
>    eyes happier.

That is absolutely fine with me.

> 3. The newly introduced parameters lack documentation in
>    our setup's manual. ☺

I look into this.


> In any case: I've pushed a patch based on your code to our repository
> just now: ae3538fac9f47958ea9566b2b3818547684f8e76 — it addresses
> everything from my earlier enumeration. As always, thanks for your
> input and let us know if the code I pushed lacks something you need.

I have tested it and it does what i expect. So everything is nice.
Actually i have an other thing in mind. Since this is a completly different
issue i open a new bugreport for that.

> Frank Terbeck added the comment:
> 
> Correction. I had to rebase my branch onto some new changes in
> the repository, so the changes hash is actually:
> fd3a55f78b1e316727760a92dcd3f0759013549c

What did i wrong that you think you can throw a sha1 at me and know what to do
with it. grml  ;)


Thank you!



kind regards,

     Thilo


> ----------
> assignedto:  -> ft
> nosy: +ft
> status: unread -> fixed-in-git
> 
> _____________________________________
> GRML issue tracker <bts@bts.grml.org>
> <http://bts.grml.org/grml/issue1933>
> _____________________________________
>
msg5576 (view) Author: ft Date: 2015-10-09.18:56:03
Correction. I had to rebase my branch onto some new changes in
the repository, so the changes hash is actually:
fd3a55f78b1e316727760a92dcd3f0759013549c
msg5575 (view) Author: ft Date: 2015-10-09.18:53:54
Hi Thilo.

I've looked at your patch this afternoon. A couple of things:

1. I think your approach does more than we should: If someone
   wishes to use a different setup from ours, they should be
   able to disable our customizations. You're doing that, which
   is good. But then, I don't think we need to check for any
   predefined styles.

2. My eyes tripped over the GRML_COMPLFOO names a couple of
   times. This is purely subjective of course. But I've changed
   the names to GRML_COMP_FOO which for some reason make my
   eyes happier.

3. The newly introduced parameters lack documentation in
   our setup's manual. ☺

In any case: I've pushed a patch based on your code to our repository
just now: ae3538fac9f47958ea9566b2b3818547684f8e76 — it addresses
everything from my earlier enumeration. As always, thanks for your
input and let us know if the code I pushed lacks something you need.


Regards, Frank
msg5574 (view) Author: Xk2c Date: 2015-10-07.18:13:06
Hello grml folks,

again i come here with a itch in grmls zshrc which i would like to see to get fixed.

When i started using grmls zshrc i wondered why completion sometimes is soo
slow. Some back and forth later i now nailed it down.

---<---<---<---<---<---<---<---<---<---<---<---<---<---<---<---<---<
    # caching
    [[ -d $ZSHDIR/cache ]] && zstyle ':completion:*' use-cache yes && \
                            zstyle ':completion::complete:*' cache-path
$ZSHDIR/cache/
---<---<---<---<---<---<---<---<---<---<---<---<---<---<---<---<---<

Since i didn't had this directory this did not work for me.

The attached patch should improve this.
Additional features:
  * Completion caching is now activated by default. It can be turned off by
    setting $GRML_NO_COMPLCACHING to s.th. non-zero prior to sourcing grmls
    zshrc.

  * location of completion cache dir is now configurable via
    $GRML_COMPLCACHE_DIR

Please have a look into this patch and eventually include it.

A hint about this patch:
I am not sure whether completion caching is wanted on live cds.
If not this should be straight forward to implement, espacially with this
patch applied.   ;)

kind regards,

     Thilo Six
History
Date User Action Args
2015-10-21 21:31:20mikasetstatus: fixed-in-git -> resolved
messages: + msg5591
2015-10-10 12:59:42ftsetmessages: + msg5582
2015-10-10 11:43:08Xk2csetmessages: + msg5581
2015-10-10 09:37:34Xk2csetmessages: + msg5577
2015-10-09 18:56:03ftsetmessages: + msg5576
2015-10-09 18:53:54ftsetstatus: unread -> fixed-in-git
assignedto: ft
messages: + msg5575
nosy: + ft
2015-10-07 18:15:02Xk2csettopic: + has patch
2015-10-07 18:13:06Xk2ccreate