BTS

Issue382

Title grml-scripts::caps-ctrl: Using $(...) instead of backticks.
Priority feature Status resolved
Superseder Nosy List ft, maddi, mika, z3ttacht
Assigned To mika Topics zsh

Created on 2008-01-23.19:06:08 by z3ttacht, last changed 2010-02-28.22:30:52 by mika.

Files
File name Uploaded Type Edit Remove
grml-scripts_caps-ctrl_delete-autoload-colors.diff z3ttacht, 2008-02-12.14:08:18 text/x-diff
grml-scripts_caps_ctrl_no_backticks.patch z3ttacht, 2008-01-23.19:06:08 text/x-diff
Messages
msg3091 (view) Author: mika Date: 2010-02-28.22:30:50
We believe that your issue has been closed by the upload of
Version 1.2.9 of grml-scripts from Michael Prokop <mika@grml.org>.
The explanation is attached below

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 28 Feb 2010 23:28:16 +0100
Source: grml-scripts
Binary: grml-scripts
Architecture: source amd64
Version: 1.2.9
Distribution: unstable
Urgency: low
Maintainer: Michael Prokop <mika@grml.org>
Changed-By: Michael Prokop <mika@grml.org>
Description: 
 grml-scripts - some small scripts which should make life easier
Changes: 
 grml-scripts (1.2.9) unstable; urgency=low
 .
   * caps-ctrl: using $(...) instead of backticks and do not load
     colors module any longer. Thanks to Alexander Steinböck.
     [Closes: issue382]
Checksums-Sha1: 
 875865e360b8f6b31d32394f214da447f53db907 954 grml-scripts_1.2.9.dsc
 bbc968ba22ead3ecd32526701cd4c38f25eb311c 211294 grml-scripts_1.2.9.tar.gz
 d44cae8fda52a026aec64f65dfc762698654b7d6 241120 grml-scripts_1.2.9_amd64.deb
Checksums-Sha256: 
 b18613dc4bcadd8451af274dd4cfebd4cde9a3480d1118a74f28c56e873d08e9 954 grml-scripts_1.2.9.dsc
 6aa618385609a616c97937e15cfd64a356efc0043a8f98c579c2354fde938519 211294 grml-scripts_1.2.9.tar.gz
 6683d0103657f46ebcf13f834660e5994e86b98e9768657698a5e75b5cddf74f 241120 grml-scripts_1.2.9_amd64.deb
Files: 
 7708f05739d784f556e97e64a23fb5c3 954 utils optional grml-scripts_1.2.9.dsc
 b0a1b336b7ad60cd2fa933639b166d75 211294 utils optional grml-scripts_1.2.9.tar.gz
 ebb32e19f8a873d78b035a9bd5bea7e0 241120 utils optional grml-scripts_1.2.9_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLiu4u2N9T+zficugRAixRAJ4sQ5qWWYDyLmp04Y1xwjCQ8GY0igCeMDBk
AdF8Z1CuvSV6ToBbdrtAq+k=
=uZ4o
-----END PGP SIGNATURE-----
msg3070 (view) Author: mika Date: 2010-02-28.01:14:03
Fixed in git, thanks to the contributors.
msg2152 (view) Author: mika Date: 2009-04-07.07:29:07
Thanks, Frank. Alex: if we can get rid of zsh within caps-ctrl that would be 
fine. If it's too much effort than just keep it as it is. Which patches should 
I apply?

regards,
-mika-
msg2147 (view) Author: ft Date: 2009-04-06.23:38:55
This issue had it's status changed but no message was send as to what
happened. Therefore I'm querying you guys for the status of this one.

The appended patches look obviously correct.
Just the repeat-vs-for sub-issue seems to be unhandled (and actually
not discussed at all).

Regards, Frank
msg1173 (view) Author: z3ttacht Date: 2008-02-12.16:02:28
> In association to that, how eager are we to switch this function to
> /bin/dash?
> IMHO the only zsh-feature used is `repeat 15 echo -n' which can easily
> be substituted by a for-loop in dash.
And afaics, that's not even nessecary.

  ,----[ man 5 keymaps ]-
  | If you enter a key definition line with only and exactly one
  | action code after the equals sign, it has a special meaning. If
  | the code (numeric or symbolic) is not an ASCII letter, it means
  | the code is implicitly replicated through all columns being
  | defined.
  `----
msg1172 (view) Author: z3ttacht Date: 2008-02-12.14:08:18
I guess `autoload -U colors ; colors' is left from an older version.
Imho it's, due to the use of `/etc/grml/lsb-functions', obsolete.

In association to that, how eager are we to switch this function to
/bin/dash?
IMHO the only zsh-feature used is `repeat 15 echo -n' which can easily
be substituted by a for-loop in dash.
But then check4progs doesn't work either, I guess. So we would have to
test for the needed programs in a more classic way, à la [[ -x ]] or
by a local function check4progs.
msg1097 (view) Author: mika Date: 2008-01-25.23:07:59
Thanks for your work, Alex - I'm setting it to "deferred" because I'd like to 
see such stuff integrated in grml after we have released the new stable 
release. I'll apply your patch then, thanks.

regards,
-mika-
msg1087 (view) Author: z3ttacht Date: 2008-01-23.19:06:08
Using $(...) instead of backticks in caps-ctrl, following grml's
policy for shell scripts.
<http://grml.org/policy -- 5.4. Good practices for shellscript>
History
Date User Action Args
2010-02-28 22:30:52mikasetstatus: fixed-in-git -> resolved
nosy: mika, maddi, ft, z3ttacht
messages: + msg3091
2010-02-28 01:14:03mikasetstatus: in-progress -> fixed-in-git
nosy: mika, maddi, ft, z3ttacht
messages: + msg3070
2009-04-07 11:20:56ftsetnosy: + ft
2009-04-07 07:29:09mikasetnosy: mika, maddi, z3ttacht
messages: + msg2152
2009-04-06 23:38:56ftsetnosy: mika, maddi, z3ttacht
messages: + msg2147
2009-02-12 20:32:08mrusetstatus: deferred -> in-progress
nosy: mika, maddi, z3ttacht
2008-02-12 16:02:29z3ttachtsetnosy: mika, maddi, z3ttacht
messages: + msg1173
2008-02-12 14:08:19z3ttachtsetfiles: + grml-scripts_caps-ctrl_delete-autoload-colors.diff
nosy: mika, maddi, z3ttacht
messages: + msg1172
2008-01-25 23:08:00mikasetstatus: unread -> deferred
assignedto: mika
messages: + msg1097
nosy: mika, maddi, z3ttacht
2008-01-23 19:06:08z3ttachtcreate