Message1214

Author ft
Recipients mika, z3ttacht
Date 2008-02-22.14:19:54
Content
Alexander Steinböck <bts@bts.grml.org>:
> Alexander Steinböck <z3ttacht@grml.org> added the comment:
> * Frank Terbeck <bts@bts.grml.org> [2008-02-06 12:25]:
> > > And `help' is completing with brackets attached.
> > > Culprit's the leading colon.
> > Um, I just tried the completion. What is your problem with the way it
> > currently works? I don't see any 'brackets attached'.
> When completing, I get
> 
>      % grml-x -<TAB>
>      Completing - option
>      [...]
>      -help         -- [display help]
>      [...]
> 
> because in _grml-x there's defined:
> 
>     '-help:[display help]'

Yeah, well. I tried this with my zsh setup, which obviously does some
things differently then grml's setup. I am able to reproduce the
problem, using grml's setup.

However, I think your fix is not the best solution, we can provide. I
am attaching two exports. Please review. I *think* they are ready for
inclusion.

One minor bit, which requires fixing, too (I guess):

[snip]
-  '-display:display for xserver:(7 8)'
+  '-display[display for xserver]:display:(7 8)'
[snap]

'7' and '8' as the only completions for -display? Reason?


> > check_com() *would* be available for completions, too. I mean, in what
> > environment are you using compsys *without* being in an interactive
> > shell?
> Right.
> 
> > However, I tend to agree with you. Leave check_com() out.
> I guess, I did mean it the same way, but you obviously managed to
> explain it in a  more understandable way.

Just for the record:
  check_com() is available outside of our zshrc now.

Regards, Frank

-- 
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
                                                  -- RFC 1925
Files
File name Uploaded
grml-x-1of2-dd65614ab2c7.diff ft, 2008-02-22.14:19:53
grml-x-2of2-431dbba93cd0.diff ft, 2008-02-22.14:19:54
History
Date User Action Args
2008-02-22 14:19:55ftsetrecipients: + z3ttacht
2008-02-22 14:19:55ftlinkissue398 messages
2008-02-22 14:19:54ftcreate