BTS

Issue660

Title grml-policy needs a serious bit of love
Priority wish Status dead
Superseder Nosy List ft, mika
Assigned To Topics

Created on 2009-04-07.11:56:11 by ft, last changed 2011-11-07.09:13:28 by mika.

Messages
msg4001 (view) Author: mika Date: 2011-11-07.09:13:28
There was no progress more for more than a year, marking this issue as dead. 
Instead I'll open a new bugreport regarding a "How to contribute" document which 
might reuse what we've in grml-policy.
msg2935 (view) Author: mika Date: 2010-02-26.13:04:33
We don't ship grml-policy nor is it an official policy yet, we have to discuss 
the "what's our git workflow for Grml/Debian packages" as well before we can 
fix the grml-policy accordingly. Therfore marking this issue as "needs-
progress" and lowering priority to "wish".
msg2163 (view) Author: ft Date: 2009-04-07.13:32:35
Michael Prokop <bts@bts.grml.org>:
> * Frank Terbeck <bts@bts.grml.org> [20090407 13:56]:
[...]
> >   b) I don't see how -z is any clearer than -n in shell tests.
> 
> It's not the -z/-n itself but the else:
> 
> if foo ; then
>    $short_part
> else
>    $long_part
> fi
> 
> instead of:
> 
> if foo ; then
>    $long_part
> else
>    $short_part
> fi

Well, is this worth putting into a policy, that's rather a requirement
for code to be accepted? I think stuff like this turns out correctly
most of the time.

Furthermore, I'd prefer to contradict the above if that makes the code
more logical and the test easier to read. (A simple example would be,
when one test is trivial and another is hard to get right, but only
the hard one creates the desired version).

What I did for now is to put a "when-in-rome-do-it-as-the-romans-do"
comment (1f92c80958cd90d9a0f419ea97828fff4d850ad8).

> >   c) We don't use mercurial anymore. Examples need to be about git.
> 
> ACK :)

[x] done in: 9820b9337b8814283f7ef8cfab85c0201daa1c3f

So, what's left is the "incomplete" part.
That'll probably stay that way for a while. We should probably discuss
what we want in there, possibly on the grml-devel mailing list.

My work-in-progress (which contains the commit hashes used herein) is
in ft/policy-wip, at:
http://git.grml.org/?p=grml-policy.git;a=shortlog;h=refs/heads/ft/policy-wip

Regards, Frank
msg2162 (view) Author: mika Date: 2009-04-07.13:05:22
* Frank Terbeck <bts@bts.grml.org> [20090407 13:56]:

> I've got some issues with grml-policy:
>   a) It's incomplete. No news here.

ACK

>   b) I don't see how -z is any clearer than -n in shell tests.

It's not the -z/-n itself but the else:

if foo ; then
   $short_part
else
   $long_part
fi

instead of:

if foo ; then
   $long_part
else
   $short_part
fi

>   c) We don't use mercurial anymore. Examples need to be about git.

ACK :)

regards,
-mika-
msg2160 (view) Author: ft Date: 2009-04-07.11:56:10
I've got some issues with grml-policy:
  a) It's incomplete. No news here.
  b) I don't see how -z is any clearer than -n in shell tests.
  c) We don't use mercurial anymore. Examples need to be about git.

issue342 is probably related to this one.

Regards, Frank
History
Date User Action Args
2011-11-07 09:13:28mikasetstatus: needs-progress -> dead
nosy: mika, ft
messages: + msg4001
2010-02-26 13:04:34mikasetpriority: bug -> wish
status: chatting -> needs-progress
messages: + msg2935
nosy: mika, ft
2009-04-07 13:32:37ftsetnosy: mika, ft
messages: + msg2163
2009-04-07 13:05:22mikasetnosy: mika, ft
messages: + msg2162
2009-04-07 12:02:31ftsetpriority: bug
status: unread -> chatting
nosy: + mika
2009-04-07 11:56:11ftcreate