BTS

Issue997

Title replace ogg2mp3_192 with 2mp3_192 or at least work around bug in oggdec
Priority feature Status wont-fix
Superseder Nosy List btittelbach, ft
Assigned To ft Topics zsh

Created on 2011-05-27.17:27:16 by btittelbach, last changed 2011-11-07.19:20:28 by btittelbach.

Files
File name Uploaded Type Edit Remove
grml-zshrc-2mp3.patch btittelbach, 2011-05-27.17:30:57 text/x-patch
grml-zshrc-ogg2mp3.patch btittelbach, 2011-05-27.17:27:16 text/x-patch
Messages
msg4069 (view) Author: btittelbach Date: 2011-11-07.19:20:28
Also I am glad to see that grml zshrc is being rid of legacy code and functions. :-)
msg4068 (view) Author: btittelbach Date: 2011-11-07.19:19:22
no problem. I actually prefer it to be stripped out of the grml zshrc
altogether. That makes it easier for me to maintain it as separate autoloaded
function file which get's loaded on demand only. :-)
msg4050 (view) Author: mika Date: 2011-11-07.14:17:07
Thanks for the patch, but a short discussion within the team resulted in the decision that we don't want to 
feature this ogg2/mp3/... stuff any longer in our grml-zshrc.

Rational: it depends on installed software that might not be present at all, might make problems in specific 
versions,... and is out of the core feature set of grml-zshrc, given its line count. Instead we suggest to 
place such stuff into the user's private zshrc(.local) configuration.

thanks && sorry :)
regards,
-mika-
msg3820 (view) Author: btittelbach Date: 2011-05-27.17:30:57
since ogg2mp3 still has problems, I also wrote grml-zshrc-2mp3.patch
features:
* supports flac and ogg
* preserves basic id3tags
* includes documentation patch
* also works around oggdec bug
* works with multiple arguments i.e. 2mp3_192 *.flac *.ogg
* backward compatible to ogg2mp3_192
msg3819 (view) Author: btittelbach Date: 2011-05-27.17:27:16
bug in oggdec, so not really a bug in ogg2mp3_192, so marked as feature

problem: 
  "oggdec -o - |"  outputs it's version string to stdout as well as the decoded
audiofile
fix:
  "oggdec -Q -o - |" fixes the problem.

grml-zshrc-ogg2mp3.patch fixes the problem and adds better lame options
History
Date User Action Args
2011-11-07 19:20:28btittelbachsetmessages: + msg4069
2011-11-07 19:19:22btittelbachsetmessages: + msg4068
2011-11-07 14:17:07mikasetstatus: chatting -> wont-fix
messages: + msg4050
2011-05-27 17:30:58btittelbachsetfiles: + grml-zshrc-2mp3.patch
status: unread -> chatting
messages: + msg3820
2011-05-27 17:27:16btittelbachcreate