Alexander Steinböck <bts@bts.grml.org>:
> 
> Alexander Steinböck <z3ttacht@grml.org> added the comment:
> 
> Option listing of some MPlayer power completions are disordered. I.e.
> 'fbmplayer' 'mplayer -vo -fs -zoom fbdev ' Therefore MPlayer is
> searching for a file called 'fbdev'.

Yes. Good catch.
And this supports my theory, that *noone* actually uses this expansion
for such aliases (see my previous mail).

[...]
> The output video driver must be specified after `-vo'.
> 
> Merging of all completions regarding MPlayer into one section as well.

This message, I like.

[...]

Personally, I'd have prefered to have the moving around of 'cx' to be
in its own commit, but hey, I'm probably taking things too far right
now. :-)

> +    'cx' 'chmod +x '
> @@ -829,21 +830,20 @@ abk=(
> -    'cmplayer' 'mplayer -vo -fs -zoom fbdev '
> -    'fbmplayer' 'mplayer -vo -fs -zoom fbdev '
> +    'cmplayer'  'mplayer -vo fbdev -fs -zoom '
> +    'fbmplayer' 'mplayer -vo fbdev -fs -zoom '
> +    'fb2' 'mplayer -vo fbdev -fs -zoom -xy 2 1>/dev/null '
> +    'fb3' 'mplayer -vo fbdev -fs -zoom -xy 3 1>/dev/null '
> +    'mp'  'mplayer -vo xv -fs -zoom '
> -    'cx' 'chmod +x '
> -    'fb2' '=mplayer -vo fbdev -fs -zoom 1>/dev/null -xy 2 '
> -    'fb3' '=mplayer -vo fbdev -fs  -zoom 1>/dev/null -xy 3 '
> -    'mp' 'mplayer -vo xv -fs -zoom '

Otherwise, the patch looks fine, and should be in after the other one
get its update.

Regards, Frank