Michael Prokop <bts@bts.grml.org>:
> Frank Terbeck <ft@bewatermyfriend.org> [20090214 20:54]:
> > Alexander Steinböck <bts@bts.grml.org>:
> > > > And what I said about "take the unneeded expansions out": scratch
> > > > that. It's cleaner if that's done in a separate patch. Either
> > > > *before* (which is probably preferable) or *after* the patch
> > > > discussed in this bug. I'm fine either way, just don't squash it
> > > > into one patch.
> > > That does still apply, I guess.
>
> > Yes.
>
> Alright, then I'll apply and push
> http://bts.grml.org/grml/file195/0001-zshrc-Add-a-trailing-space-for-several-power-comple.patch
Actually, I think Alexander meant if my earlier remark still applies.
IIRC, I made a review with comments that are still standing out to be
corrected.
So, unless you're in a hurry, I'd say we give Alexander the time he
needs to come up with a cleaned up patch.
Regards, Frank |