Thilo Six wrote:
[...]
> Thats it! It has been tested in bash (4.2.45) and zsh (5.0.2) and verified that
> it works as aspected.
Great!
[...]
> In script-functions there is one more change the discussed allready.
> I changed the vim modeline:
>
> -# vim:foldmethod=marker tw=80 ai expandtab shiftwidth=2 tabstop=8
> +# vim:foldmethod=marker tw=80 ai expandtab shiftwidth=2 tabstop=8 ft=sh
[...]
Since this is another unrelated change, I'd usually request two separate
patches. But since you're getting to learn git (and probably version
control as a whole) just now, I'll split them up manually.
Actually, we could split this up even more, since the does two things:
- Add the --silent etc. options
- Switch from ‘which’ to looping over $PATH.
But then again I'm lazy, so lets not over-engineer this. ;)
For the record, I'll attach patches for the two commits, that I will
push in just a minute. If the patches are formatted like this (the git
format-patch utility helps with this) the integration work on our side
is minimal. ;)
Regards, Frank |