BTS

Message4971

Author Xk2c
Recipients
Date 2015-05-24.20:01:33
Content
Frank Terbeck schrieb/wrote:

-- <snip> --
> The #f1# line needs to be located directly above the "sll() {" line,

check.

> I'd like this to be
> 
>     if ...; then

check.

-- <snip> --
> Also for consistency, "local -i RTN ..." and "local -a SEENINODES" here.

check.

-- <snip> --
> Also for consistency
> 
>     for i in ...; do

check.

Updated patch attached. It also fixes a bug in symlink loop detection.
I ran a complete test suite to make sure no regression is introduced.


> Other than that, this looks good to me.
> 
> Thanks for your work!

Thank you for your review!



kind regards,

     Thilo
Files
File name Uploaded
0001-patch-b_sll_updated.patch Xk2c, 2015-05-24.20:01:33
History
Date User Action Args
2015-05-24 20:01:33Xk2clinkissue1351 messages
2015-05-24 20:01:33Xk2ccreate