BTS

Message802

Author ft1
Recipients ft, mika
Date 2007-09-16.11:33:25
Content
Michael Prokop <mika@grml.org>:
> * Frank Terbeck <ft@grml.org> [20070916 12:47]:
> > Michael Prokop <mika@grml.org>:
> > > * ft <bts@bts.grml.org> [20070916 12:10]:
> > > > add_suffix
> > > > ebegin
> > > > eend                    [required]
> > > > eerror                  [required]
> > > > eindent                 [required]
> > > > einfo                   [required]
> > > > einfon                  [required]
> > > > eoutdent                [required]
> > > > esetdent
> > > > esyslog                 [required]
> > > > ewarn                   [required]
> > > > ewend

> > These just do 'return 0'. Unless you think they are needed I'll remove
> > them:
> 
> We have such functions also in /etc/grml/script-functions and
> /etc/grml/sh-lib. I'd like to merge as much as possible. I

            ^- I don't think this works in (d)ash as it is.
               The required change would be simple, though.
               I *think*

            ^- This one required 'gawk'; G(!)awk

            ^- pure sh, AFAICS; works recursively, too.
               Handy for time-stamping. Don't know if we need it.
               The implementation looks fairly clean.

            ^- Pure sh. I rewrote this one to make it work with
               (d)ash.

            ^- This requires 'awk'

> appreciate any feedback. :) [Though I'm not yet sure how to create a
> new "API" without breaking anything, maybe we should clean up

Yeah, a test-suite would be handy. :)
Maybe, now that you got grml-live, it would be possible to create
experimental ISOs. That way, we could "just do it", and see what
happens.

> lsb-functions as far as possible (without breaking any scripts) and
> provide all the useful functions for scripts (interactive as well as
> init-style scripts) in a new file (could be even
> /etc/grml/script-functions as I'm the only one really using it
> AFAICS).

Well, I think it would be a good idea to keep the functions that are
*really* required by LSB in lsb-functions. Everything else (namely the
e*() functions) can savely go to another file, like
'script-functions', if you like.

My grep expression also missed these:
    log_success_msg()       [used]
    log_failure_msg()       [used]
    log_warning_msg()       [used]
    log_warning_msg_nn()
    log_begin_msg()         [used]
    log_begin_msg_nn()      [used]
    log_end_msg()           [used]

At least log_success_msg(), log_failure_msg(), log_warning_msg() are
required by lsb. So, we should keep all of them.

Removed functions I snipped from this posting, as requested.

Regards, Frank
History
Date User Action Args
2007-09-16 11:33:26ft1setrecipients: + ft
2007-09-16 11:33:26ft1linkissue290 messages
2007-09-16 11:33:25ft1create