* Frank Terbeck <ft@bewatermyfriend.org> [20070916 13:33]:
> Michael Prokop <mika@grml.org>:
> > * Frank Terbeck <ft@grml.org> [20070916 12:47]:

> > We have such functions also in /etc/grml/script-functions and
> > /etc/grml/sh-lib. I'd like to merge as much as possible. I

> Are you talking about these: (?)

Jupp

> > > > > get_bootconfig
>             ^- I don't think this works in (d)ash as it is.
>                The required change would be simple, though.
>                I *think*

Ok, then lets drop it and we write our own implementation for
script-functions

> > > > > get_bootparam
>             ^- This one required 'gawk'; G(!)awk

same here

> > > > > is_older_than
>             ^- pure sh, AFAICS; works recursively, too.
>                Handy for time-stamping. Don't know if we need it.
>                The implementation looks fairly clean.

Hm, lets move it to script-functions?

> > > > > reverse_list
>             ^- Pure sh. I rewrote this one to make it work with
>                (d)ash.

candidate for script-functions as well

> > > > > get_mount_fstab
>             ^- This requires 'awk'

let's drop it

> > appreciate any feedback. :) [Though I'm not yet sure how to create a
> > new "API" without breaking anything, maybe we should clean up

> Yeah, a test-suite would be handy. :)
> Maybe, now that you got grml-live, it would be possible to create
> experimental ISOs. That way, we could "just do it", and see what
> happens.

Sure, that's my long term goal. :)

> > lsb-functions as far as possible (without breaking any scripts) and
> > provide all the useful functions for scripts (interactive as well as
> > init-style scripts) in a new file (could be even
> > /etc/grml/script-functions as I'm the only one really using it
> > AFAICS).

> Well, I think it would be a good idea to keep the functions that are
> *really* required by LSB in lsb-functions. Everything else (namely the
> e*() functions) can savely go to another file, like
> 'script-functions', if you like.

ACK

> My grep expression also missed these:
>     log_success_msg()       [used]
>     log_failure_msg()       [used]
>     log_warning_msg()       [used]
>     log_warning_msg_nn()
>     log_begin_msg()         [used]
>     log_begin_msg_nn()      [used]
>     log_end_msg()           [used]

> At least log_success_msg(), log_failure_msg(), log_warning_msg() are
> required by lsb. So, we should keep all of them.

ACK

> Removed functions I snipped from this posting, as requested.

Great

regards,
-mika-