BTS

Issue1350

Title grml-etc-core/etc/zsh/zshrc - clutters enviroment
Priority bug Status resolved
Superseder Nosy List Xk2c
Assigned To Topics

Created on 2015-05-14.11:18:02 by Xk2c, last changed 2015-06-06.00:02:19 by mika.

Files
File name Uploaded Type Edit Remove
0001-Removed-some-variables-from-entering-running-zsh-env.patch Xk2c, 2015-05-14.13:09:22 text/x-diff
grml-etc-core:etc:zsh:zshrc.patch Xk2c, 2015-05-14.11:18:01 text/x-diff
zshrc Xk2c, 2015-05-14.12:13:08 application/octet-stream
Messages
msg5007 (view) Author: mika Date: 2015-06-06.00:02:19
We believe that your issue has been closed by the upload of
Version 0.12.0 of grml-etc-core from Michael Prokop <mika@grml.org>.
The explanation is attached below

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 06 Jun 2015 01:42:49 +0200
Source: grml-etc-core
Binary: grml-etc-core
Architecture: source all
Version: 0.12.0
Distribution: grml-testing
Urgency: medium
Maintainer: Michael Prokop <mika@grml.org>
Changed-By: Michael Prokop <mika@grml.org>
Description:
 grml-etc-core - core etcetera files for the Grml system
Changes:
 grml-etc-core (0.12.0) grml-testing; urgency=medium
 .
   [ Thomas 'Moviuro' Berger ]
   * [8945506] zshrc: we use getopts on salias()
   * [cbe11aa] zshrc: bk(): better usage/help handling
   * [9c33cea] minimal-shellrc: make sure that aliases refer to 'command ls'
   * [386c0c4] zshrc: bk(): don't use while but for
   * [8e8677d] zshrc: unify cat<< syntax
   * [b9a7056] zshrc: `cat' is not needed in the `cat <<' syntax
   * [dbd02d7] zshrc: add support for `fetch' in simple-extract()
   * [46c2d10] zshrc: simplify cdt()
   * [d6c9e08] README.md: curl(1) now follows redirects
 .
   [ Michael Vetter ]
   * [2b66bf6] zshrc: Correct comment sentences
 .
   [ Michael Prokop ]
   * [43d4533] zshrc: drop insecure options from curl/wget cmdlines in
     simple-extract()
 .
   [ Thilo Six ]
   * [fdb957e] zshrc: avoid cluttering environment [Closes: issue1350]
 .
   [ Christian Hesse ]
   * [e3f3b08] zshrc: fix ssh remote host name completion with more
     than one pattern
 .
   [ Dr. András Korn ]
   * [6948820] zshenv: avoid placing empty components in PATH; reorder
     root's PATH
 .
   [ Frank Terbeck ]
   * [c4db6d7] zshrc: add static version of add-zsh-hook
Checksums-Sha1:
 38b17ec33fc9481599b3d36048ac89bf56ba92ee 1577 grml-etc-core_0.12.0.dsc
 7f3fa82791d33c9d7671e94c8bc3953915e636eb 157779 grml-etc-core_0.12.0.tar.gz
 5743624d04e0b0c9c63c8fdc797a1eef43625515 144150 grml-etc-core_0.12.0_all.deb
Checksums-Sha256:
 b8975b5432edd4476fed821129c87103b232ff8cd290ebc3fdd6350df9c27528 1577 grml-etc-core_0.12.0.dsc
 9afa063168b7b55e6403d966653421e137503ea6307803cca8bb9dd0e7eeb292 157779 grml-etc-core_0.12.0.tar.gz
 5d967d5996b43ef83a6d1f7aed56ba091c54e734235f36f8d268c60e17d2a45c 144150 grml-etc-core_0.12.0_all.deb
Files:
 bb4d98fff7eebecb4567ec2469b82e98 1577 grml optional grml-etc-core_0.12.0.dsc
 a9421eba404b6c640ef4a1bb80f8bcd1 157779 grml optional grml-etc-core_0.12.0.tar.gz
 631b44bd3ccb612394f3a0878bee6ac8 144150 grml optional grml-etc-core_0.12.0_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJVcjYLAAoJEJaoeHK36jc3/BoQAJGAQt+petNKW0QV+OMDxtqp
k9gwfAATw1WCAqY+7MkqpRMjbAp053tTgfUW49lO4nJxJLdn+inAVN/VHiGtpFbZ
fvDBc+P1tOpLTz39ES0DCRorsCO47Z1D+tUnyo1ZV6UBvAcN6QiPeoNyVgeg52Vx
wTzE1Fpfe/JEanhBPIAbBriWngXL1Pul52g73BQ+Qx5HUD4bldZzxnohO6zOXTC7
4MT6DScw4y/IB8HkWj8xTQTFYnRNNyA1JDv+py+TQKplMt7Gco/wvCYOCr07CxoD
ARwOSs+3m1UeCa1JmONB5fNZe/p1e3QBY/hv2yZ6IqkATO9AWaOZBHAdyl/XEXzV
A7putUBFAvlVQ7Yur7SDLRrGtNOPM7IhCtbuGVmdALptOvBLvm32c6YB9x2FWv3k
0bWDzARd0fgs+IeCPii96HdGHTyrZWRU00phq0VyOqIZ30rgNaWh4x0XAesAeCwY
Q11AGKrkYU8FWvtljvs69QImPQkaQabsDm8iwg0omedLsivCllH/3dhnQGBhPQ0L
G9H2N0/HcM/TAEw5EpYjCM0bTospjGBxVxXJ5iEBZKzidUdutww7XV6iulYj1eX9
uBd75w0NdsHosuS4Rxx2aeklpYU63Ur+5Etgry0MPeRTQdjPRjS+gLQmWWT9C+zO
XLYn5pPOsy8FxGEHl0gv
=07Ni
-----END PGP SIGNATURE-----
msg4954 (view) Author: mika Date: 2015-05-15.21:20:08
Hej,

* Thilo Six wrote in grml's BTS on 20150514 / 15:09:

> ...and now as git patch.
> Hope i did it right. Have done this the first time. ;)

Thanks, applied!

JFTR, I slightly adjusted the git commit message (even though I
forgot to prepend the "zshrc:", meh :)).

Thanks!

regards,
-mika-
msg4953 (view) Author: Xk2c Date: 2015-05-14.13:09:22
...and now as git patch.

Hope i did it right. Have done this the first time. ;)

bye Thilo
msg4952 (view) Author: Xk2c Date: 2015-05-14.12:13:08
Hello

i figured i would also attach the full resulting /etc/zsh/zshrc.
Done now.

bye Thilo
msg4951 (view) Author: Xk2c Date: 2015-05-14.11:18:01
Dear Grml Maintainers and Zsh-lovers,  ;)

you are known to take great care to not clutter environment, when using your
/etc/zsh/zshrc as base.

I figured non the less some used variables has fallen through.
In particular this example cause real bugs:

<<<<< >8 <<<<< >8 <<<<< >8 <<<<< >8 <<<<< >8 <<<<<
# make sure our environment is clean regarding colors
for color in BLUE RED GREEN CYAN YELLOW MAGENTA WHITE ; unset $color
<<<<< >8 <<<<< >8 <<<<< >8 <<<<< >8 <<<<< >8 <<<<<

here the var color is defined, which is expected by other scripts and functions
to be an array.

Attached is a patch which fixes this and some more.

I hope i didn't break anything. A 4 eyes reviewing can't hurt though.

Thanks!

bye Thilo
History
Date User Action Args
2015-06-06 00:02:19mikasetstatus: fixed-in-git -> resolved
messages: + msg5007
2015-05-15 21:42:43mikasetstatus: chatting -> fixed-in-git
2015-05-15 21:20:08mikasetmessages: + msg4954
2015-05-14 13:09:22Xk2csetfiles: + 0001-Removed-some-variables-from-entering-running-zsh-env.patch
messages: + msg4953
2015-05-14 12:13:08Xk2csetfiles: + zshrc
status: unread -> chatting
messages: + msg4952
2015-05-14 11:18:02Xk2ccreate