BTS

Issue314

Title integrate vimrc_grmlHeader
Priority feature Status wont-fix
Superseder Nosy List ft, mika, z3ttacht
Assigned To Topics

Created on 2007-10-13.22:54:21 by mika, last changed 2010-02-28.00:51:21 by mika.

Files
File name Uploaded Type Edit Remove
vimrc_grmlHeader mika, 2007-10-13.22:54:21 application/octet-stream
Messages
msg3061 (view) Author: mika Date: 2010-02-28.00:51:21
Merged ft/policy-wip into master of grml-policy.git, marking this bugreport as 
"won't fix" as discussed. 

thx && regards,
-mika-
msg2293 (view) Author: ft Date: 2009-06-13.10:30:01
Michael Prokop <bts@bts.grml.org>:
> Michael Prokop <mika@grml.org> added the comment:
> * Frank Terbeck <bts@bts.grml.org> [20090613 11:55]:
[...]
> > Also: I don't think the header makes much sense any more.
> 
> > We're using git.
> > That means, we have *detailed* information about when a file what last
> > changed.
> 
> ACK, and "Latest changes" causes headaches when merging stuff.
> So I'm dropping this stuff out of every file which I'm updating anyway.

Good. :)

[...]
> > Filename:
> > maybe Purpose:. Maybe.
> > Author: (And I think "grml-team (grml.org)" would suffice.)
> 
> Good idea, I hate the "who should we include into the Author field
> overall" problem anyway. Let's use instead grml-team. Do we want to
> use something like that? ->
> 
> Author(s):   grml team (http://grml.org/)

Yes, exactly.

> > Bug-Reports: maybe. And if, we should make sure the right URL is used.
> 
> http://grml.org/bugs/ is the right place IMO, because it provides
> all the necessary information for users.

Okay.

> > License: GPL v2 (unless otherwise noted)
> 
> > Those headers don't need constant updating.
> 
> ACK
> 
> > I'm voting for "won't fix" here. Don't add redundant information
> > without reason.
> 
> How to we want to proceed? Should we provide a good, ACK-ed template
> in the grml-policy (which requires some action anyway as you're
> aware ;))?


Well, "won't fix" this issue, merge ft/policy-wip of grml-policy.git
into its master. Add a note about what header we generally expect for
new files in grml.

Regards, Frank
msg2292 (view) Author: mika Date: 2009-06-13.10:19:29
* Frank Terbeck <bts@bts.grml.org> [20090613 11:55]:

> Holy smoke.

> I just looked at the code.

> Do we actually want this much code for a feature that's boiling in the
> bts for 1.5 years without anyone really getting it working?

> Also: I don't think the header makes much sense any more.

> We're using git.
> That means, we have *detailed* information about when a file what last
> changed.

ACK, and "Latest changes" causes headaches when merging stuff.
So I'm dropping this stuff out of every file which I'm updating anyway.

> That means, we _have_ *detailed* information about who changed a file.
> About who changed what _line_ and _when_ (git blame/annotate).

> I really think these headers make sense:

> Filename:
> maybe Purpose:. Maybe.
> Author: (And I think "grml-team (grml.org)" would suffice.)

Good idea, I hate the "who should we include into the Author field
overall" problem anyway. Let's use instead grml-team. Do we want to
use something like that? ->

Author(s):   grml team (http://grml.org/)

> Bug-Reports: maybe. And if, we should make sure the right URL is used.

http://grml.org/bugs/ is the right place IMO, because it provides
all the necessary information for users.

> License: GPL v2 (unless otherwise noted)

> Those headers don't need constant updating.

ACK

> I'm voting for "won't fix" here. Don't add redundant information
> without reason.

How to we want to proceed? Should we provide a good, ACK-ed template
in the grml-policy (which requires some action anyway as you're
aware ;))?

regards,
-mika-
msg2290 (view) Author: ft Date: 2009-06-13.09:55:10
Holy smoke.

I just looked at the code.

Do we actually want this much code for a feature that's boiling in the
bts for 1.5 years without anyone really getting it working?

Also: I don't think the header makes much sense any more.

We're using git.
That means, we have *detailed* information about when a file what last
changed.

That means, we _have_ *detailed* information about who changed a file.
About who changed what _line_ and _when_ (git blame/annotate).

I really think these headers make sense:

Filename:
maybe Purpose:. Maybe.
Author: (And I think "grml-team (grml.org)" would suffice.)
Bug-Reports: maybe. And if, we should make sure the right URL is used.
License: GPL v2 (unless otherwise noted)

Those headers don't need constant updating.

I'm voting for "won't fix" here. Don't add redundant information
without reason.

Regards, Frank
msg2155 (view) Author: mika Date: 2009-04-07.07:54:31
* Frank Terbeck <bts@bts.grml.org> [20090407 02:03]:

> Obvious question: 1.5 year old issue with solution attached.
> Is the solution not good enough? Do we want to do this differently?
> Do we want this at all? Was this just forgotten?

> Regards, Frank - who fills up people's Inbox tonight. :)

Yeah, great :)

I just give it a try. First issue:

| Tried to find out your real name and email adress.
| Please verfiy them. They will be saved in /home/mika/.vim/userdata for further usage.
| Is your email adress correct? 

=> *which* email ad*d*ress is correct? Please display it. :)

And then the following errors appear (IIRC it's the same issue I
experienced long time ago, though it's not document in the BTS
AFAICS yet):

| Tried to find out your real name and email adress.
| Please verfiy them. They will be saved in /home/mika/.vim/userdata for further usage.
| Is your email adress correct?                                                        line   44:
| E121: Undefined variable: g:com
| E116: Invalid arguments for function setline
| line   46:
| E121: Undefined variable: g:com
| E116: Invalid arguments for function append
| [...]

Oh and: the 'Latest change' isn't needed anymore as you might know
(so we don't run into automatic merge problems), I guess this should
even simplify fixing it.

Alex, do you care updating the patch so we can ship it via
/etc/skel/.vimrc?

regards,
-mika-
msg2150 (view) Author: ft Date: 2009-04-07.00:03:47
Obvious question: 1.5 year old issue with solution attached.
Is the solution not good enough? Do we want to do this differently?
Do we want this at all? Was this just forgotten?

Regards, Frank - who fills up people's Inbox tonight. :)
msg880 (view) Author: mika Date: 2007-10-13.22:54:21
See attached file, contributed by Alexander 'Stone' Steinböck.
History
Date User Action Args
2010-02-28 00:51:21mikasetstatus: chatting -> wont-fix
nosy: mika, ft, z3ttacht
messages: + msg3061
2009-06-13 10:30:03ftsetnosy: mika, ft, z3ttacht
messages: + msg2293
2009-06-13 10:19:32mikasetnosy: mika, ft, z3ttacht
messages: + msg2292
2009-06-13 09:55:14ftsetnosy: mika, ft, z3ttacht
messages: + msg2290
2009-04-07 11:18:23ftsetnosy: + z3ttacht, ft, - z3ttacht
2009-04-07 07:54:32mikasetnosy: mika, z3ttacht
messages: + msg2155
2009-04-07 00:03:47ftsetstatus: unread -> chatting
nosy: mika, z3ttacht
messages: + msg2150
2007-10-13 22:54:21mikacreate