BTS

Issue916

Title code for serial console is not idempotent
Priority bug Status resolved
Superseder Nosy List ch, mika
Assigned To Topics release-stopper

Created on 2010-10-24.22:57:11 by mika, last changed 2010-10-26.21:01:13 by mika.

Messages
msg3406 (view) Author: mika Date: 2010-10-26.21:01:12
We believe that your issue has been closed by the upload of
Version 0.9.15 of grml-autoconfig from Michael Prokop <mika@grml.org>.
The explanation is attached below

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 26 Oct 2010 22:55:49 +0200
Source: grml-autoconfig
Binary: grml-autoconfig
Architecture: source all
Version: 0.9.15
Distribution: unstable
Urgency: low
Maintainer: Michael Prokop <mika@grml.org>
Changed-By: Michael Prokop <mika@grml.org>
Description: 
 grml-autoconfig - main bootup process of a Grml (based) system
Changes: 
 grml-autoconfig (0.9.15) unstable; urgency=low
 .
   [ Christian Hofstaedtler ]
   * [a9ef28a] fix handling of multiple console= options.
     [Closes: issue916]
Checksums-Sha1: 
 b8d6eed6b6984b4e956882e1d2ffacf14fd1ac57 958 grml-autoconfig_0.9.15.dsc
 f19d2796d94104cbb6b4a422c16dd1f2ea295e5a 71409 grml-autoconfig_0.9.15.tar.gz
 9f3355052405163aa166c6f415d34090c4cdb43c 90234 grml-autoconfig_0.9.15_all.deb
Checksums-Sha256: 
 75a212a78b53986ed0bf8a5a95adfa5bc3430fe142b9148e876883dc1c084395 958 grml-autoconfig_0.9.15.dsc
 afb4b8271b506e036cff92e6a119c598c892a980cb4b9d5c8f681d42444a0bd1 71409 grml-autoconfig_0.9.15.tar.gz
 6f72160590c39bf32006c7512192dc3a66c5d4e101b3b240e97635ace4196110 90234 grml-autoconfig_0.9.15_all.deb
Files: 
 c66f180c243b3ee4f119d4e0b43164a3 958 grml optional grml-autoconfig_0.9.15.dsc
 5efdb336feefa6d0dda72fd657fcd029 71409 grml optional grml-autoconfig_0.9.15.tar.gz
 bbcdad749984aed69a79cc62624eca42 90234 grml optional grml-autoconfig_0.9.15_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkzHQJUACgkQ2N9T+zficujBoACfT83LiqLbnhI4i934fKCnUb5e
0KkAoISQNNllhglMB40pxmRn5GMWS4Az
=hyom
-----END PGP SIGNATURE-----
msg3402 (view) Author: ch Date: 2010-10-26.19:58:13
Fixed with a9ef28a9082b24866dcbd5769dcc6c51f09b4ec3 in grml-autoconfig.git.
msg3399 (view) Author: mika Date: 2010-10-26.19:02:33
ACK, no objections against removing from my side.
msg3398 (view) Author: ch Date: 2010-10-26.18:58:02
This can probably be made idempotent by dropping the fallback for console=ttyN 
(sans S). What is the point of the fallback anyway?
msg3395 (view) Author: mika Date: 2010-10-24.22:57:10
Using "console=tty1 console=ttyS0" for booting generates a broken /etc/inittab, 
resulting in (c/p of a serial connection):

 * Bootoption for serial console detected:
 * Warning: console=ttyS... not specified as last console= option. Fall  [ ok ] 
to set up ttyS0/9600.
 *   Activating console login on device tty1 with speed .                [ ok ]
 *   Activating console login on device ttyS0 with speed 115200,57600,3  
[ ok ]00,9600,4800,2400,1200.
INIT: /etc/inittab[71]: id field too long (max 4 characters)
INIT: /etc/inittab[72]: duplicate ID field "T0"                          [ ok ]

Executing:

  . /etc/grml/autoconfig.functions
  config_console

then once again generates further broken entries in /etc/inittab. The code 
should handle the tty* options in the cmdline accordingly and has to be 
idempotent.
History
Date User Action Args
2010-10-26 21:01:13mikasetstatus: chatting -> resolved
nosy: mika, ch
messages: + msg3406
2010-10-26 19:58:13chsetnosy: mika, ch
messages: + msg3402
2010-10-26 19:02:33mikasetnosy: mika, ch
messages: + msg3399
2010-10-26 18:58:02chsetstatus: unread -> chatting
nosy: + ch
messages: + msg3398
2010-10-24 22:57:11mikacreate