BTS

Issue626

Title Rewrite of XF86Audio{{Lower,Raise}Volume,Mute}.
Priority feature Status resolved
Superseder replace aumix with alsamixer
View: 625
Nosy List ft, mika, z3ttacht
Assigned To mika Topics

Created on 2009-02-18.13:28:30 by z3ttacht, last changed 2011-11-26.17:31:33 by mika.

Files
File name Uploaded Type Edit Remove
0001-Rewrite-of-XF86Audio-Lower-Raise-Volume-Mute.patch z3ttacht, 2009-02-19.18:08:22 text/x-diff
Messages
msg4088 (view) Author: mika Date: 2011-11-26.17:31:33
We believe that your issue has been closed by the upload of
Version 2.0.2 of grml-scripts from Michael Prokop <mika@grml.org>.
The explanation is attached below

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 26 Nov 2011 18:10:11 +0100
Source: grml-scripts
Binary: grml-scripts
Architecture: source amd64
Version: 2.0.2
Distribution: unstable
Urgency: low
Maintainer: Michael Prokop <mika@grml.org>
Changed-By: Michael Prokop <mika@grml.org>
Description: 
 grml-scripts - Collection of little tools
Changes: 
 grml-scripts (2.0.2) unstable; urgency=low
 .
   [ Christian Hofstaedtler ]
   * [01e3faf] grml-chroot: write /etc/debian_chroot [Closes: issue953]
   * [2f61167] Remove wm-ng
   * [f11fb88] Remove X11R6 from run-welcome PATH
   * [df294f8] Add welcome beep (disable with nobeep)
 .
   [ Michael Prokop ]
   * [65eedce] drop XF86Audio{LowerVolume,Mute,RaiseVolume} scripts
     [Closes: issue626]
Checksums-Sha1: 
 d5c12f5d12e7e004422ee76485726eeceff3d2ae 980 grml-scripts_2.0.2.dsc
 652961b81db99aa684a29187bca69aee4584913c 97624 grml-scripts_2.0.2.tar.gz
 a2856bb8bbc78fe617f60d032c757f61404c581b 109258 grml-scripts_2.0.2_amd64.deb
Checksums-Sha256: 
 1551bcffdee6184871fadf98fc9485063035be5a330e5cd8a87559694e02fd29 980 grml-scripts_2.0.2.dsc
 a7ecde730aa024d9a1c672e28385e6821368e93a4a1fef85d23ff1c65b18f6ed 97624 grml-scripts_2.0.2.tar.gz
 30b2b28e3d1d7d8a7db2f8a57da886f154d73e6b6809c4ec3b27d95d07a50e3e 109258 grml-scripts_2.0.2_amd64.deb
Files: 
 0df2123dec1904b1bfc12d645833e0a5 980 utils optional grml-scripts_2.0.2.dsc
 361b3341789d025181f0229718b353f6 97624 utils optional grml-scripts_2.0.2.tar.gz
 f37b23aec7dde15a85d87f75fef1c594 109258 utils optional grml-scripts_2.0.2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk7RHrEACgkQ2N9T+zficui0DACeLRbSS0vFHIf2Sjfqo9pnvAd5
UoYAnR1osTGRd4yZgGKymdrUNKWMIAKt
=yqFp
-----END PGP SIGNATURE-----
msg4037 (view) Author: mika Date: 2011-11-07.13:41:17
XF86Audio* will be gone with next upload of grml-scripts.
msg3069 (view) Author: mika Date: 2010-02-28.01:09:35
This one needs further investigation, I'm a bit unhappy about the way the sound 
handling within grml-autoconfig as well as the XF86Audio* scripts works 
nowadays.
msg2283 (view) Author: mika Date: 2009-06-12.23:50:23
Alex/z3ttacht: what's the current state of this issue? It's related to Issue625 
and I'd like to merge it into grml-scripts. Anything speaking against it?

thx && regards,
-mika-
msg1918 (view) Author: z3ttacht Date: 2009-02-19.18:08:22
Updated the skript to be more read- and maintainable. At least I hope
so. (o;
msg1914 (view) Author: mika Date: 2009-02-19.16:37:43
* Frank Terbeck [20090218 16:30]:

> > > Can we see some code somewhere?

> > Damn it! I really forgot to attach the patch. My bad!

> Heh. That's okay. I don't have the time to review right now, though...
> Mika?

Yeah, Alex is working on an updated patch, I'll take care of it then
(but no need to hury). I highly appreciate Alex's work in this area
cause it's bugging me since quite a long time already and I never
had the time to work on it.

regards,
-mika-
msg1909 (view) Author: ft Date: 2009-02-18.15:30:00
Alexander Steinböck <bts@bts.grml.org>:
> 
> Alexander Steinböck <z3ttacht@grml.org> added the comment:
> 
> > Can we see some code somewhere?
> Damn it! I really forgot to attach the patch. My bad!

Heh. That's okay. I don't have the time to review right now, though...
Mika?

Regards, Frank
msg1906 (view) Author: z3ttacht Date: 2009-02-18.13:49:16
> Can we see some code somewhere?
Damn it! I really forgot to attach the patch. My bad!
msg1905 (view) Author: ft Date: 2009-02-18.13:34:17
Alexander Steinböck <bts@bts.grml.org>:
> New submission from Alexander Steinböck <z3ttacht@grml.org>:
> 
> The big changes by this commit are:
> 
>   * Existence of '/etc/grml/lsb-functions' isn't mandatory anymore.

-v?

>   * Just using amixer(1) for querying and setting the various mixer. Before
>     amixer(1) _and_ aumix(1) were used. But amixer doesn't work with
                                              ^- aumix, I presume?

>     grml-medium 2008.11 due to lack of module snd-mixer-oss. [s. Issue625]
> 
>   * A 'config file' for parameters to osd_cat(1) is used, which gets read by
>     grep(1). Therefore changes according osd_cat's settings can easily be made
>     in just one place for every instance.

Read by grep!?

>   * No temporary file is used anymore.

That certainly sounds good.

>   * `XF86AudioRaiseVolume' changes `XF86AudioLowerVolume' with the help of
>     sed(1) on the fly, since the two scripts just differ in two places.
>        1. amixer -q --sset Master 5%-  vs.  amixer -q --sset Master 5%+
>        2. Lowered volume               vs.  Raised volume

I don't see where sed fits into the picture here.
Can we see some code somewhere?

Regards, Frank
msg1904 (view) Author: z3ttacht Date: 2009-02-18.13:28:30
The big changes by this commit are:

  * Existence of '/etc/grml/lsb-functions' isn't mandatory anymore.

  * Just using amixer(1) for querying and setting the various mixer. Before
    amixer(1) _and_ aumix(1) were used. But amixer doesn't work with
    grml-medium 2008.11 due to lack of module snd-mixer-oss. [s. Issue625]

  * A 'config file' for parameters to osd_cat(1) is used, which gets read by
    grep(1). Therefore changes according osd_cat's settings can easily be made
    in just one place for every instance.

  * No temporary file is used anymore.

  * `XF86AudioRaiseVolume' changes `XF86AudioLowerVolume' with the help of
    sed(1) on the fly, since the two scripts just differ in two places.
       1. amixer -q --sset Master 5%-  vs.  amixer -q --sset Master 5%+
       2. Lowered volume               vs.  Raised volume
History
Date User Action Args
2011-11-26 17:31:33mikasetstatus: fixed-in-git -> resolved
nosy: mika, ft, z3ttacht
messages: + msg4088
2011-11-07 13:41:17mikasetstatus: needs-progress -> fixed-in-git
nosy: mika, ft, z3ttacht
messages: + msg4037
2010-02-28 01:09:35mikasetnosy: mika, ft, z3ttacht
messages: + msg3069
2009-06-12 23:50:48mikasetstatus: need-eg -> needs-progress
nosy: mika, ft, z3ttacht
2009-06-12 23:50:28mikasetstatus: chatting -> need-eg
nosy: mika, ft, z3ttacht
2009-06-12 23:50:23mikasetnosy: mika, ft, z3ttacht
superseder: + replace aumix with alsamixer
messages: + msg2283
2009-02-27 12:12:38z3ttachtsetnosy: mika, ft, z3ttacht
assignedto: mika
2009-02-19 18:08:22z3ttachtsetfiles: + 0001-Rewrite-of-XF86Audio-Lower-Raise-Volume-Mute.patch
nosy: mika, ft, z3ttacht
messages: + msg1918
2009-02-19 18:03:56z3ttachtsetfiles: - 0001-Rewrite-of-XF86Audio-Lower-Raise-Volume-Mute.patch
nosy: mika, ft, z3ttacht
2009-02-19 16:37:44mikasetnosy: mika, ft, z3ttacht
messages: + msg1914
2009-02-18 15:30:00ftsetnosy: mika, ft, z3ttacht
messages: + msg1909
2009-02-18 13:49:16z3ttachtsetfiles: + 0001-Rewrite-of-XF86Audio-Lower-Raise-Volume-Mute.patch
nosy: mika, ft, z3ttacht
messages: + msg1906
2009-02-18 13:34:17ftsetstatus: unread -> chatting
nosy: mika, ft, z3ttacht
messages: + msg1905
title: grml-scripts: Rewrite of XF86Audio{{Lower,Raise}Volume,Mute}. -> Rewrite of XF86Audio{{Lower,Raise}Volume,Mute}.
2009-02-18 13:32:50z3ttachtsetnosy: mika, ft, z3ttacht
title: Rewrite of XF86Audio{{Lower,Raise}Volume,Mute}. -> grml-scripts: Rewrite of XF86Audio{{Lower,Raise}Volume,Mute}.
2009-02-18 13:28:30z3ttachtcreate